Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vulnerability): Fix padding issue in vuln sysdetails page #2235

Merged
merged 4 commits into from
Aug 12, 2024
Merged

fix(vulnerability): Fix padding issue in vuln sysdetails page #2235

merged 4 commits into from
Aug 12, 2024

Conversation

adonispuente
Copy link
Contributor

@adonispuente adonispuente commented Aug 7, 2024 •
edited
Loading

Fixes the padding issue inside vulnerability sys details page:

To replicate the issue, just go to any sysdetails in vulnerability
before there is a massive gap inbetween the table and header:
Screenshot 2024-08-07 at 2 59 41 PM

@adonispuente adonispuente requested a review from a team as a code owner August 7, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.69%. Comparing base (d49663e) to head (667d54b).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         198      198           
  Lines        5239     5239           
  Branches     1912     1912           
=======================================
  Hits         3075     3075           
  Misses       2164     2164

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mkholjuraev
mkholjuraev approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@mkholjuraev mkholjuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @adonispuente thank you for the quick fix. Let's discuss the real cause tomorrow

@adonispuente
Copy link
Contributor Author

/retest

@adonispuente
Copy link
Contributor Author

/retest

@adonispuente
Copy link
Contributor Author

@computercamplove This ci test is failing with 18:36:45 ��� ERROR: tests hit errors or failed to collect for plugins: ['host_inventory_frontend'] , Are you aware of anything on the QE side of this that could cause that?

@bastilian
Copy link
Member

@adonispuente Have you tried removing the class here: https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Components/SmartComponents/SystemDetailsPage/SystemDetailsPage.js#L96

@adonispuente
Copy link
Contributor Author

/retest

@adonispuente adonispuente mentioned this pull request Aug 9, 2024
Merged
@adonispuente
Copy link
Contributor Author

@adonispuente Have you tried removing the class here: https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Components/SmartComponents/SystemDetailsPage/SystemDetailsPage.js#L96

RedHatInsights/vulnerability-ui#2130

@adonispuente
Copy link
Contributor Author

/retest

1 similar comment
@computercamplove
Copy link
Contributor

/retest

@adonispuente adonispuente merged commit a975ea0 into RedHatInsights:master Aug 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkholjuraev mkholjuraev mkholjuraev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adonispuente @codecov-commenter @bastilian @computercamplove @mkholjuraev